Skip to content

topology: cht-max98090 add missing virtual widgets - #1842

Merged
tlauda merged 1 commit into
thesofproject:masterfrom
cujomalainey:master
Sep 20, 2019
Merged

tlauda merged 1 commit into
thesofproject:masterfrom
cujomalainey:master

Conversation

@cujomalainey

Copy link
Copy Markdown
Contributor

Topology will fail to probe without these widgets

Signed-off-by: Curtis Malainey cujomalainey@google.com

Topology will fail to probe without these widgets

Signed-off-by: Curtis Malainey <cujomalainey@google.com>

@ranj063 ranj063 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cujomalainey the change itself looks fine but what do you mean by "topology will fail to probe". Previously, we've added virtual widgets only to suppress errors ugh(harmless though) due to the widgets added in the machine driver.

@plbossart

Copy link
Copy Markdown
Member

@cujomalainey the change itself looks fine but what do you mean by "topology will fail to probe". Previously, we've added virtual widgets only to suppress errors ugh(harmless though) due to the widgets added in the machine driver.

wondering if the recent changes from Morimoto-san treat bad routes using non-existent widgets as errors. I think we saw this for HDaudio/iDISP as well.

@ranj063

ranj063 commented Sep 18, 2019

Copy link
Copy Markdown
Collaborator

wondering if the recent changes from Morimoto-san treat bad routes using non-existent widgets as errors. I think we saw this for HDaudio/iDISP as well.

@plbossart I've reviewed every one of his patches lately but cant recollect anything that touches non-existent widgets. I can remove the virtual widgets from our topology for iDisp and see whats going on

@plbossart

plbossart commented Sep 18, 2019 via email

Copy link
Copy Markdown
Member

@plbossart

plbossart commented Sep 18, 2019 •

Copy link
Copy Markdown
Member

for iDISP the kernel patch that caused the error was (' ASoC: soc-core: tidyup for snd_soc_dapm_add_routes()')

@lgirdwood lgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we good to merge ? I see approvals but no "request changes" ?

@plbossart plbossart left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is aligned with the other BYT stuff.

I am not clear why for APL+ we also defined virtual widgets for codec0/1_out/in or why we use VIRTUAL_DAPM_ROUTE for those widgets. Maybe this should be a follow-up PR to align everyone and make those macros less inspired by voodoo magic.

@cujomalainey

cujomalainey commented Sep 19, 2019 •

Copy link
Copy Markdown
Contributor Author

@ranj063 these are the failures I am seeing on ToT

[   36.507756] cht-bsw-max98090 cht-bsw-max98090: snd-soc-dummy-dai <-> Low Latency 0 mapping ok
[   36.507821] cht-bsw-max98090 cht-bsw-max98090: ASoC: no source widget found for ssp2 Tx
[   36.507827] cht-bsw-max98090 cht-bsw-max98090: ASoC: Failed to add route ssp2 Tx -> direct -> HiFi Playback
[   36.507834] cht-bsw-max98090 cht-bsw-max98090: ASoC: no sink widget found for ssp2 Tx
[   36.507839] cht-bsw-max98090 cht-bsw-max98090: ASoC: Failed to add route codec_out0 -> direct -> ssp2 Tx
[   36.507845] cht-bsw-max98090 cht-bsw-max98090: ASoC: no sink widget found for ssp2 Tx
[   36.507850] cht-bsw-max98090 cht-bsw-max98090: ASoC: Failed to add route codec_out1 -> direct -> ssp2 Tx
[   36.507856] cht-bsw-max98090 cht-bsw-max98090: ASoC: no source widget found for ssp2 Rx
[   36.507861] cht-bsw-max98090 cht-bsw-max98090: ASoC: Failed to add route ssp2 Rx -> direct -> codec_in0
[   36.507868] cht-bsw-max98090 cht-bsw-max98090: ASoC: no source widget found for ssp2 Rx
[   36.507872] cht-bsw-max98090 cht-bsw-max98090: ASoC: Failed to add route ssp2 Rx -> direct -> codec_in1
[   36.507879] cht-bsw-max98090 cht-bsw-max98090: ASoC: no sink widget found for ssp2 Rx
[   36.507883] cht-bsw-max98090 cht-bsw-max98090: ASoC: Failed to add route HiFi Capture -> direct -> ssp2 Rx
[   36.508180] cht-bsw-max98090 cht-bsw-max98090: snd_soc_register_card failed -19

@tlauda
tlauda merged commit 1571af1 into thesofproject:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants